#3649 - Stop printing replacement message when config is not changed

rubygems · May 16, 2015 · 6506ac5 · 6506ac5
1 parent 49c9784
commit 6506ac5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/bundler/cli/config.rb b/lib/bundler/cli/config.rb
@@ -59,7 +59,7 @@ def run
               "This will take precedence over the global value you are setting"
           end
 
-          if global = locations[:global]
+          if global = locations[:global] and global != locations[:global]
             Bundler.ui.info "You are replacing the current global value of #{name}, which is currently #{global.inspect}"
           end
         end

diff --git a/spec/commands/config_spec.rb b/spec/commands/config_spec.rb
@@ -96,6 +96,15 @@
       expect(out).to eq("global")
     end
 
+    it "do not warns when using the same value twice" do
+      bundle "config --global foo value"
+      bundle "config --global foo value"
+      expect(out).not_to match(/You are replacing the current global value of foo/)
+
+      run "puts Bundler.settings[:foo]"
+      expect(out).to eq("value")
+    end
+
     it "expands the path at time of setting" do
       bundle "config --global local.foo .."
       run "puts Bundler.settings['local.foo']"