[RuboCop] Enable Style/RedundantSelf

rubygems · Nov 26, 2015 · d5f3f86 · d5f3f86
1 parent 277e0ff
commit d5f3f86
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 19 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -246,18 +246,6 @@ Style/PredicateName:
 Style/RaiseArgs:
   Enabled: false
 
-# Offense count: 7
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/bundler.rb'
-    - 'lib/bundler/definition.rb'
-    - 'lib/bundler/graph.rb'
-    - 'lib/bundler/rubygems_integration.rb'
-    - 'lib/bundler/source/rubygems.rb'
-    - 'spec/support/less_than_proc.rb'
-    - 'spec/support/ruby_ext.rb'
-
 # Offense count: 1
 # Configuration parameters: Methods.
 Style/SingleLineBlockParams:

diff --git a/lib/bundler.rb b/lib/bundler.rb
@@ -175,7 +175,7 @@ def app_config_path
 
     def app_cache(custom_path = nil)
       path = custom_path || root
-      path.join(self.settings.app_cache_path)
+      path.join(settings.app_cache_path)
     end
 
     def tmp(name = Process.pid.to_s)

diff --git a/lib/bundler/definition.rb b/lib/bundler/definition.rb
@@ -661,7 +661,7 @@ def pinned_spec_names(specs)
     end
 
     def requested_groups
-      self.groups - Bundler.settings.without - @optional_groups + Bundler.settings.with
+      groups - Bundler.settings.without - @optional_groups + Bundler.settings.with
     end
 
     def lockfiles_equal?(current, proposed, preserve_bundled_with)

diff --git a/lib/bundler/graph.rb b/lib/bundler/graph.rb
@@ -97,7 +97,7 @@ def _patching_gem_dependency_class
       Gem::Dependency.class_eval do
         def matching_specs(platform_only = false)
           matches = Bundler.load.specs.select { |spec|
-            self.name == spec.name and
+            name == spec.name and
               requirement.satisfied_by? spec.version
           }
 

diff --git a/lib/bundler/rubygems_integration.rb b/lib/bundler/rubygems_integration.rb
@@ -203,7 +203,7 @@ def fetch_all_remote_specs(remote)
 
     def with_build_args(args)
       ext_lock.synchronize do
-        old_args = self.build_args
+        old_args = build_args
         begin
           self.build_args = args
           yield

diff --git a/lib/bundler/source/rubygems.rb b/lib/bundler/source/rubygems.rb
@@ -68,7 +68,7 @@ def to_lock
       end
 
       def to_s
-        remote_names = self.remotes.map(&:to_s).join(", ")
+        remote_names = remotes.map(&:to_s).join(", ")
         "rubygems repository #{remote_names}"
       end
       alias_method :name, :to_s

diff --git a/spec/support/less_than_proc.rb b/spec/support/less_than_proc.rb
@@ -3,7 +3,7 @@ class LessThanProc < Proc
 
   def self.with(present)
     provided = Gem::Version.new(present.dup)
-    self.new do |required|
+    new do |required|
       if required =~ /[=><~]/
         !Gem::Requirement.new(required).satisfied_by?(provided)
       else

diff --git a/spec/support/ruby_ext.rb b/spec/support/ruby_ext.rb
@@ -9,7 +9,7 @@ def read_available_bytes(chunk_size = 16_384, select_timeout = 0.02)
       begin
         IO.select([self], nil, nil, select_timeout)
         break if eof? # stop raising :-(
-        buffer << self.readpartial(chunk_size)
+        buffer << readpartial(chunk_size)
       rescue(EOFError)
         break
       end