Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Added README.md to newgem #1574

Merged
merged 1 commit into from Dec 6, 2011
Merged

Added README.md to newgem #1574

merged 1 commit into from Dec 6, 2011

Conversation

ognevsky
Copy link
Contributor

@ognevsky ognevsky commented Dec 3, 2011

No description provided.

@sferik
Copy link
Member

sferik commented Dec 3, 2011

I'm not a fan of the tone of step 6 in the Contributing section ("Wait"). Maybe it could be something a little bit nicer?

@ognevsky
Copy link
Contributor Author

ognevsky commented Dec 3, 2011

@sferik maybe you have any suggestions? Like this one:

6. ???
7. PROFIT

Or something more official. English is not my native, so it's rather hard to me.

@JDutil
Copy link

JDutil commented Dec 3, 2011

I think it would be fine to just remove step 6 altogether.

@JDutil
Copy link

JDutil commented Dec 3, 2011

Also for installation instructions rather than having it be todo it could explain how to add the gem to the Gemfile. The authors can make updates if it's any more difficult than that or they have a particular version.

Installation

Add to your Gemfile:

gem '<%=config[:constant_name]%>'

Download dependencies:

$ bundle

@ognevsky
Copy link
Contributor Author

ognevsky commented Dec 3, 2011

@JDutil not even thinking about this, it's very useful.

But there should be config[:name], not config[:constant_name], but I've got the idea.

@JDutil
Copy link

JDutil commented Dec 3, 2011

Thanks @ognevsky

* Added README.md to newgem
* Removed 'Wait' list item
* Added Installation instructions
@ognevsky
Copy link
Contributor Author

ognevsky commented Dec 6, 2011

@sferik it's ready for merge, i think.

sferik added a commit that referenced this pull request Dec 6, 2011
@sferik sferik merged commit 95e57b3 into rubygems:master Dec 6, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants