This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Ensure #dump doesn't add a new line in config #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure whether |
Fixes rubygems#2821 * YAML#dump without any option parameters hard-wraps a string at 80 characters and this causes errors while reading the config file and parsing it. * There is another way to fix this: Modify the Regex that is used for parsing the config file. The current regex supports only a single line of "key: value" type statements. Presumably, YAML#load is not used for security reasons and so, this is the only other option. modified: lib/bundler/settings.rb modified: spec/commands/config_spec.rb
|
I guess worst case, limit this change to 1.9 and greater? We still need to have the dumping and parsing work on 1.8.7, even if we can't fix the wrapping bug. (I would also be open to a regex change that handles the line breaks). |
|
Yeah, I think a regex change would be the best solution until bundler is `> 1.9.x' only. Will try that out. |
* The option :line_width is available only in the YAML library and not in the older Syck and since we need to cater to installations that run Ruby versions below 1.9, this solution is not useful. * The new regex will take into account newlines and will parse the configuration options accordingly. This makes it work even in Ruby 1.8.7
|
The failure in Travis is not related to the changed code. |
indirect
added a commit
that referenced
this pull request
Feb 17, 2014
Ensure #dump doesn't add a new line in config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2821
YAML#dump without any option parameters hard-wraps a string at 80
characters and this causes errors while reading the config file
and parsing it.
There is another way to fix this: Modify the Regex that is used for
parsing the config file. The current regex supports only a single line
of "key: value" type statements. Presumably, YAML#load is not used for
security reasons and so, this is the only other option.
modified: lib/bundler/settings.rb
modified: spec/commands/config_spec.rb