Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Documentation should not recommend 'git://' URLs #2958

Closed
peter-mtso opened this issue Apr 1, 2014 · 3 comments
Closed

Documentation should not recommend 'git://' URLs #2958

peter-mtso opened this issue Apr 1, 2014 · 3 comments

Comments

@peter-mtso
Copy link
Contributor

git:// URLs allow a network "man-in-the-middle" attacker to easily substitute malicious code and compromise the user's machine. We should note this issue in the documentation and stop recommending this pattern. It seems irresponsible to provide examples which can get users compromised, while not even mentioning the problem or secure alternatives.

(In the future, warnings for insecure URLs would be great, too)

@skottler
Copy link
Member

skottler commented Apr 1, 2014

I agree, @peter-mtso. HTTPS should be the default because git over SSH requires that you have a private key known to the Git daemon available on the machine you're cloning (or subsequently bundling) from.

Would you mind submitting a pull request to fix this?

@peter-mtso
Copy link
Contributor Author

Sure, I can put together a draft for changes to the manpage and the website.

@skottler
Copy link
Member

skottler commented Apr 1, 2014

Cool, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants