This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Remove relative path enforcement on --cache-path #5627
Labels
Comments
|
@indirect given you added the customizable cache path and the commit doesn't seem to justify why only relative paths are allowed, I think this is for you to answer |
|
Oh man, I have no idea what I was thinking. It seems fine to allow absolute paths to me? I guess, for what it's worth, in Bundler 2.0 there will be a user-wide shared cache of .gems by default. |
|
are we breaking backwards compatibility if we take that exception out? |
|
Nah, it's the other direction that would be a problem. Allowing users to do something they couldn't before (adding a "feature") is never breaking backwards compatibility |
bundlerbot
added a commit
that referenced
this issue
May 2, 2017
Permit absolute paths in cache_path setting Removes check on leading `/` from `cache_path` and updates tests. Fixes #5627
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Would it be possible to remove the check done on
--cache-pathhere?Used in conjunction with
--no-pruneit would then be possible to more easily maintain a central cache ofgemfiles useable by multiple local apps. In the case where apps have many common libraries (that are often, if not always, in sync) this is quite useful.The text was updated successfully, but these errors were encountered: