This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Permit absolute paths in cache_path setting #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
reviewed
Apr 30, 2017
spec/cache/cache_path_spec.rb
Outdated
| @@ -23,12 +23,4 @@ | |||
| expect(bundled_app("vendor/cache-foo/rack-1.0.0.gem")).to exist | |||
| end | |||
| end | |||
|
|
|||
| context "when given an absolute path" do | |||
| it "exits with non-zero status" do | |||
There was a problem hiding this comment.
can we change this to a test that it packages correctly?
lib/bundler/settings.rb
Outdated
| path = self[:cache_path] || "vendor/cache" | ||
| raise InvalidOption, "Cache path must be relative to the bundle path" if path.start_with?("/") | ||
| path | ||
| self[:cache_path] || "vendor/cache" |
There was a problem hiding this comment.
The begin block is no longer necessary here
DEFAULT_VENDOR_CACHE_PATH = "vendor/cache"
...
def app_cache_path
@app_cache_path ||= self[:cache_path] || DEFAULT_VENDOR_CACHE_PATH
end
There was a problem hiding this comment.
I've held off extracting "vendor/cache" into a constant for now because it didn't appear to fit with the rest of the file. It makes sense to do but perhaps as part of a separate wider scoped refactor.
mal
force-pushed
the
permit-absolute-cache-path
branch
from
08ead2f
to
8fce595
Compare
|
👍🏻 |
|
@bundlerbot r+ |
|
📌 Commit 8fce595 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
May 2, 2017
Permit absolute paths in cache_path setting Removes check on leading `/` from `cache_path` and updates tests. Fixes #5627
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes check on leading
/fromcache_pathand updates tests.Fixes #5627