Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Added -t option for bundle gem to generate a .travis.yml file with the current Ruby version #2143

Merged
merged 1 commit into from
Jan 26, 2013

Conversation

ndbroadbent
Copy link
Contributor

A lot of open source gems are running their tests on Travis CI.

This PR adds the option to generate an minimal (but functional) .travis.yml config file, so you can start testing on Travis CI right away.

Let me know if you think we should make this a default file, and remove the option. Gems are usually open source, so it might be cool to encourage testing on Travis CI.

@rohitarondekar
Copy link
Contributor

This sounds like a nice idea. But lets keep it as an option IMHO.

One nitpick regarding the banner for the option ― I think something like this will read better: "Generate a default configuration for Travis CI."

@ndbroadbent
Copy link
Contributor Author

I'm also happy with keeping in an option. Great suggestion for the banner, yours is a lot better :)

@rohitarondekar
Copy link
Contributor

There is already an option assigned for -t on bundler master. It's supposed to generate a test folder. Before you make changes I think it will be best to ask @indirect if this PR is a desired feature? :)

@indirect
Copy link
Member

@ndbroadbent can you just rebase and then add the Travis file as part of the -t/--test switch? It only makes sense to me to have a travis file if your gem has tests. :)

@ndbroadbent
Copy link
Contributor Author

Rebased, and added to the --test option. (Doesn't hurt to have even if the gem isn't tested on Travis.)

@indirect
Copy link
Member

Sounds reasonable to me. Thanks!

indirect added a commit that referenced this pull request Jan 26, 2013
Added -t option for `bundle gem` to generate a .travis.yml file with the current Ruby version
@indirect indirect merged commit 00a416b into rubygems:master Jan 26, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants