Added -t option for `bundle gem` to generate a .travis.yml file with the current Ruby version #2143

Merged
merged 1 commit into from Jan 26, 2013

Conversation

Projects
None yet
3 participants
Contributor

ndbroadbent commented Nov 2, 2012

A lot of open source gems are running their tests on Travis CI.

This PR adds the option to generate an minimal (but functional) .travis.yml config file, so you can start testing on Travis CI right away.

Let me know if you think we should make this a default file, and remove the option. Gems are usually open source, so it might be cool to encourage testing on Travis CI.

Contributor

rohit commented Nov 2, 2012

This sounds like a nice idea. But lets keep it as an option IMHO.

One nitpick regarding the banner for the option ― I think something like this will read better: "Generate a default configuration for Travis CI."

Contributor

ndbroadbent commented Nov 2, 2012

I'm also happy with keeping in an option. Great suggestion for the banner, yours is a lot better :)

Contributor

rohit commented Nov 22, 2012

There is already an option assigned for -t on bundler master. It's supposed to generate a test folder. Before you make changes I think it will be best to ask @indirect if this PR is a desired feature? :)

Owner

indirect commented Nov 22, 2012

@ndbroadbent can you just rebase and then add the Travis file as part of the -t/--test switch? It only makes sense to me to have a travis file if your gem has tests. :)

Contributor

ndbroadbent commented Jan 24, 2013

Rebased, and added to the --test option. (Doesn't hurt to have even if the gem isn't tested on Travis.)

Owner

indirect commented Jan 26, 2013

Sounds reasonable to me. Thanks!

@indirect indirect added a commit that referenced this pull request Jan 26, 2013

@indirect indirect Merge pull request #2143 from ndbroadbent/travis_ci_template
Added -t option for `bundle gem` to generate a .travis.yml file with the current Ruby version
00a416b

@indirect indirect merged commit 00a416b into bundler:master Jan 26, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment