Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

nicer default gemspec #3115

Closed
wants to merge 1 commit into from
Closed

nicer default gemspec #3115

wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jul 27, 2014

  • simpler require / version should always be loadable without loadin any other dependencies
  • use normal quoting
  • no need for encoding unless you add weird characters / no need for it on 2.0+
  • require_path is the default, no need to add it

@indirect
Copy link
Member

Not adding to the load path is probably better, as long as this doesn't allow double-requiring the version file.

Regular quotes are bad for doc strings.

We can't remove encoding while Bundler supports 1.8 and 1.9.

Require path probably doesn't need to be there.

@grosser
Copy link
Contributor Author

grosser commented Jul 27, 2014

As long as everything is ascii it's fine to remove the encoding, right ?
Not sure why regular quotes are bad for docs, as long as the user does not put a double quote in there normal quotes should work just fine ?
I'll take a look if double require is possible ... otherwise I'll switch it to File.expand_path

@grosser
Copy link
Contributor Author

grosser commented Jul 27, 2014

looks fine, tried this on 2.0 / 1.9 / ree (using the same pattern in pru)

>> require './lib/pru/version'
=> true
>> $LOAD_PATH << 'lib'
>> require 'pru/version'
=> false
>>

@segiddins
Copy link
Member

@indirect can I merge this into 2-0-dev?

@indirect
Copy link
Member

@segiddins Keep the %{} strings, because it allows both kinds of quotes inside the docstrings. The other changes are 👍

@indirect indirect closed this Apr 20, 2015
@segiddins
Copy link
Member

Applied manually to 2-0-dev in 24789a1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants