This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Allow dev versions when creating a new gem #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix the build on master. |
| major, minor, *etc = Bundler::VERSION.split(".") | ||
| version = [major, minor] | ||
| version << etc.last if etc.last =~ /[a-z]/i | ||
| version.join(".") |
There was a problem hiding this comment.
I think we can just use Gem::Version to do the work for us:
v = Gem::Version.new(Bundler::VERSION)
req = v.approximate_recommendation
req << "." << v.segments.last if v.prerelease?
reqThere was a problem hiding this comment.
Even better. I'll update.
There was a problem hiding this comment.
Hmm... approximate_recommendation is only available with RG 2.0+. Previously, it had a different name: rubygems/rubygems@f5035c6
I could monkey patch in a method alias if it's not already defined, but it probably isn't worth it just for this. I'll use a hybrid of my original code and your change.
There was a problem hiding this comment.
Heh, probably not. Sounds good!
|
probably related to #2849 |
|
Yep, thanks for the pointer @simi. Not sure why that one was closed. |
indirect
added a commit
that referenced
this pull request
Feb 18, 2015
Allow dev versions when creating a new gem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed behaviour is to see if the last segment in the Bundler version contains any letters, and if so, tack it on.
So with Bundler 1.9.0.dev, you get:
and with Bundler 1.8.2, you get the same as before: