This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Forward original exception message when a require fails #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bundler failed to require a file it discarded the original message containing the reason why the require failed. This change forwards the original message into the new message. Example use case: jsonapi-resources referencing a nonexistent constant when loaded into a rails 5 project.
|
Could you please add a spec/test covering this change? |
|
I will look into that. |
|
@p ping on this? |
|
Have not had a chance to do it yet, sorry. |
|
@p do you need any guidance on adding a spec for this change? If it helps, you'd probably want to take a look at and add the test coverage here: https://github.com/bundler/bundler/blob/master/spec/runtime/require_spec.rb |
|
That is helpful, thanks! |
|
Has this been superseded by #4187 ? |
|
Closing as the functionality in this PR has been fulfilled by #4187. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bundler failed to require a file it discarded the original message containing the reason why the require failed.
This change forwards the original message into the new message.
Example use case: jsonapi-resources referencing a nonexistent constant when loaded into a rails 5 project.