This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Handle yanked gems #4606
Merged
Handle yanked gems #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| it "throws and error when there is gem yanked" do |
| raise GemNotFound, "Your bundle is locked to #{locked_gem}, but that version could not " \ | ||
| "be found in any of the sources listed in your Gemfile. If you haven't changed sources, " \ | ||
| "that means the author of #{locked_gem} has removed it. You'll need to update your bundle " \ | ||
| "to a different version of foo that hasn't been removed in order to install." |
There was a problem hiding this comment.
it says "different version of foo" in the error message. I think this should be the gem name (locked_gem), right?
There was a problem hiding this comment.
Oh, I forgot to change that
|
@allenzhao made a few comments. Other than those small changes, this LGTM. |
|
@segiddins, can you r+ this or delegate me? Thanks. |
|
@homu delegate=RochesterinNYC |
|
✌️ @RochesterinNYC can now approve this pull request |
|
@homu r+ |
|
📌 Commit 1587e0d has been approved by |
|
⚡ Test exempted - status |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4344