Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Feature-flag the postit trampoline, disabled by default #4822

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

segiddins
Copy link
Member

Set ENV["BUNDLE_ENABLE_TRAMPOLINE"] to enable it

Closes #4821

Set ENV["BUNDLE_ENABLE_TRAMPOLINE"] to enable it
@indirect
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Jul 28, 2016

📌 Commit a2fc99e has been approved by indirect

@homu
Copy link
Contributor

homu commented Jul 28, 2016

⚡ Test exempted - status

@homu homu merged commit a2fc99e into master Jul 28, 2016
homu added a commit that referenced this pull request Jul 28, 2016
Feature-flag the postit trampoline, disabled by default

Set ENV["BUNDLE_ENABLE_TRAMPOLINE"] to enable it

Closes #4821
@segiddins segiddins deleted the seg-feature-flag-trampoline branch August 15, 2016 20:12
@coilysiren coilysiren modified the milestone: Release Archive Sep 22, 2016
@Supernats
Copy link

Supernats commented Mar 18, 2019

@segiddins I realize I'm bringing this up many years after the PR has been merged and now that v2 is live, it's unlikely any changes near this section of code are desired. This is more of a question about what to expect from Bundler.

From what I can see in the patch as well as what I've been able to confirm on my local machine, in all pre-2 versions, it is only possible to enable the trampoline by setting the BUNDLE_ENABLE_TRAMPOLINE (later BUNDLE_TRAMPOLINE_FORCE) environment variables. If one then runs bundle config, a stanza for trampoline_force shows up, as would be expected. At this point, the trampoline executes as expected.

If one then sets BUNDLE_TRAMPOLINE_FORCE in the local bundle config and unsets the environment variable, bundle config still shows the same value for trampoline_force, just with a different source. At this point, if one tries any bundle command, the trampoline will not execute.

Here is my question: Why does this feature flag seemingly contradict the Bundler configuration norms set by the bundle config page? Are there other settings that don't follow the lookup described by bundle config?

In case you are curious about my use case, I was hoping to commit a .bundle/config to our repository to help standardize our Bundler version across developers without making sure everyone updated.

If this comes across as an attack, I apologize deeply and would love to know what specifically I've said to make it feel that way.

Thanks for all the work you and the rest of the Bundler team do to keep this critical piece of Ruby infrastructure working for the community.

@segiddins
Copy link
Member Author

This feature was reverted from Bundler and reimplemented in RubyGems 3

@Supernats
Copy link

Supernats commented Mar 19, 2019

Oh, okay. Thanks for the prompt response.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants