Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

[Installer] Skip eval’ing a Gemfile twice when there’s a lockfile #4952

Merged
merged 6 commits into from
Sep 10, 2016

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Sep 7, 2016

Closes #3096. Closes #4417.

\c @indirect

@indirect indirect mentioned this pull request Sep 7, 2016
23 tasks
@indirect
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Sep 10, 2016

📌 Commit a0c4b2f has been approved by indirect

@homu
Copy link
Contributor

homu commented Sep 10, 2016

⚡ Test exempted - status

@homu homu merged commit a0c4b2f into 2-0-dev Sep 10, 2016
homu added a commit that referenced this pull request Sep 10, 2016
[Installer] Skip eval’ing a Gemfile twice when there’s a lockfile

Closes #3096. Closes #4417.

\c @indirect
@segiddins segiddins deleted the seg-no-eval-gemfile-twice-2-0 branch September 16, 2016 12:43
@coilysiren coilysiren added this to the 2.0 — Breaking Changes milestone Oct 9, 2016
bundlerbot added a commit that referenced this pull request Jun 16, 2017
Eval Gemfiles one fewer time when running `bundle install`

This is just a straight port of #4952 to master from `2-0-dev`.
Unfortunately, the Gemfile is still eval'ed twice when plugins are enabled.
bundlerbot added a commit that referenced this pull request Jun 16, 2017
Eval Gemfiles one fewer time when running `bundle install`

This is just a straight port of #4952 to master from `2-0-dev`.
Unfortunately, the Gemfile is still eval'ed twice when plugins are enabled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants