Fix outdated regression from cc355865 #5171
Conversation
The only existing spec coverage was essentially integration level and there was no way either @lucasmazza or myself could find a way to simulate the bug context. I extracted some of the code out of outdated into Definition and SpecSet and added unit specs to those extracted bits.
|
@lucasmazza your feedback is welcome ... I think this gets us the test coverage we need. |
|
@chrismo this looks great, and thanks a ton for taking this over :) |
|
@chrismo hey so good news! I finally finished putting up our own Homu at @bundlerbot, and he knows to listen to you! try it out by saying 🎉 |
The only existing spec coverage was essentially integration level and there was no way either @lucasmazza or myself could find a way to simulate the bug context. I extracted some of the code out of outdated into Definition and SpecSet and added unit specs to those extracted bits. Closes: #5171 Approved by: <try>
|
(omg I put the bot name and r+ in the same comment 😂 sorry, next time though!) |
|
Oh man, even weirder. I accidentally activated |
|
@bundlerbot r+ |
|
📌 Commit 66d6b48 has been approved by |
|
there's an outstanding homu check that I think is gumming up the works. Going to close and make a separate PR. |
|
See #5176 |
Refactoring of @lucasmazza fix w/ specs.
The only existing spec coverage was essentially integration level and
there was no way either @lucasmazza or myself could find a way to
simulate the bug context.
I extracted some of the code out of outdated into Definition and
SpecSet and added unit specs to those extracted bits.
Fixes #4979