This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Fix outdated regression from cc355865 #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only existing spec coverage was essentially integration level and there was no way either @lucasmazza or myself could find a way to simulate the bug context. I extracted some of the code out of outdated into Definition and SpecSet and added unit specs to those extracted bits.
chrismo
force-pushed
the
fix_outdated_regression_from_cc355865
branch
from
66d6b48
to
b3ad170
Compare
|
|
|
@bundlerbot r+ |
|
📌 Commit b3ad170 has been approved by |
|
⚡ Test exempted - status |
bundlerbot
added a commit
that referenced
this pull request
Nov 15, 2016
…r=chrismo Fix outdated regression from cc35586 Refactoring of @lucasmazza fix w/ specs. The only existing spec coverage was essentially integration level and there was no way either @lucasmazza or myself could find a way to simulate the bug context. I extracted some of the code out of outdated into Definition and SpecSet and added unit specs to those extracted bits. Fixes #4979
This was referenced Nov 15, 2016
|
@chrismo 🎉 hooray finally r+ support |
|
yeah! very cool - thx for the work :) |
|
Q: When release including this fix will be available? |
|
@kikonen if we release a patch, it'll be |
chrismo
added a commit
to chrismo/bundler
that referenced
this pull request
Dec 23, 2016
This supersedes PR rubygems#4734, which fixed a bug but didn't have proper spec coverage. Since that PR was submitted, a different commit (291a807 in PR rubygems#5176) fixed a similar bug at the same time. That caused a merge conflict in rubygems#4734. It was unknown if the same fix fixed both bugs, since there were no successfully implemented specs. These specs show that the bug was properly fixed.
chrismo
added a commit
to chrismo/bundler
that referenced
this pull request
Dec 23, 2016
This supersedes PR rubygems#4734, which fixed a bug but didn't have proper spec coverage. Since that PR was submitted, a different commit (291a807 in PR rubygems#5176) fixed a similar bug at the same time. That caused a merge conflict in rubygems#4734. It was unknown if the same fix fixed both bugs, since there were no successfully implemented specs. These specs show that the bug was properly fixed. These specs were mostly already implemented by @b-ggs, just needed a little additional guidance.
bundlerbot
added a commit
that referenced
this pull request
Dec 23, 2016
Specs for multiple platform bug fix in outdated. This supersedes PR #4734, which fixed a bug but didn't have proper spec coverage. Since that PR was submitted, a different commit (291a807 in PR #5176) fixed a similar bug at the same time. That caused a merge conflict in #4734. It was unknown if the same fix fixed both bugs, since there were no successfully implemented specs. These specs show that the bug was properly fixed. These specs were mostly already implemented by @b-ggs, just needed a little additional guidance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of @lucasmazza fix w/ specs.
The only existing spec coverage was essentially integration level and
there was no way either @lucasmazza or myself could find a way to
simulate the bug context.
I extracted some of the code out of outdated into Definition and
SpecSet and added unit specs to those extracted bits.
Fixes #4979