Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Introduce COMPACT_INDEX_POOL env var to limit compact index thread pool #6617

Closed
wants to merge 1 commit into from

Conversation

vs-adm
Copy link

@vs-adm vs-adm commented Jul 4, 2018

This is a quick proposition to fix #6322 using ENV var COMPACT_INDEX_POOL

@ghost
Copy link

ghost commented Jul 4, 2018

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

@vs-adm vs-adm changed the title Introduce COMPACT_INDEX_POOL env rar to limit compact index thread pool Introduce COMPACT_INDEX_POOL env var to limit compact index thread pool Jul 4, 2018
@colby-swandale
Copy link
Member

Thanks for opening the PR and helping improve Bundler but we cannot accept this. We have a particular way handling configuration that uses ENV vars, see bundle config. And i don't believe this is the appropriate fix either. The issue with the linked ticket is that there is a bug in the compact index that is preventing it from handling the case of not having enough threads available. This will have to be fixed.

@vs-adm
Copy link
Author

vs-adm commented Jul 4, 2018

This is just starting point. I have no idea how to get remaining thread count on limited systems. But I can rewrite code to utilize the common way of handling ENV vars

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants