Update unit tests

bundlewatch · Jan 9, 2024 · d272492 · d272492
1 parent d26edad
commit d272492
Show file tree

Hide file tree

Showing 2 changed files with 94 additions and 58 deletions.
diff --git a/src/app/index.test.js b/src/app/index.test.js
@@ -7,15 +7,22 @@ import bundlewatchApi from '.'
 
 describe(`bundlewatch Node API`, () => {
     it('Works with basic options', async () => {
-        const result = await bundlewatchApi({
-            files: [
-                {
-                    path: './__testdata__/*.jpg',
-                    maxSize: '100kB',
-                },
-            ],
-            defaultCompression: 'none',
-        })
+        const result = await bundlewatchApi(
+            {
+                files: [
+                    {
+                        path: './__testdata__/*.jpg',
+                        maxSize: '100kB',
+                    },
+                ],
+                defaultCompression: 'none',
+            },
+            {
+                error: () => {},
+                pass: () => {},
+                fail: () => {},
+            },
+        )
 
         // TODO: assert logger.warn called
 
@@ -24,14 +31,21 @@ describe(`bundlewatch Node API`, () => {
     })
 
     it(`Works when files dont exist, shows warning`, async () => {
-        const result = await bundlewatchApi({
-            files: [
-                {
-                    path: './__testdata__/test-file-doesnt-exist.jpg',
-                    maxSize: '100kB',
-                },
-            ],
-        })
+        const result = await bundlewatchApi(
+            {
+                files: [
+                    {
+                        path: './__testdata__/test-file-doesnt-exist.jpg',
+                        maxSize: '100kB',
+                    },
+                ],
+            },
+            {
+                error: () => {},
+                pass: () => {},
+                fail: () => {},
+            },
+        )
 
         delete result.url
         expect(result).toMatchSnapshot()
@@ -64,22 +78,30 @@ describe(`bundlewatch Node API`, () => {
 
         // TODO: assert save was called
 
-        const result = await bundlewatchApi({
-            files: [
-                {
-                    path: './__testdata__/*.jpg',
-                    maxSize: '1MB',
+        const result = await bundlewatchApi(
+            {
+                files: [
+                    {
+                        path: './__testdata__/*.jpg',
+                        maxSize: '1MB',
+                    },
+                ],
+                ci: {
+                    githubAccessToken: MOCK_AUTH_TOKEN,
+                    repoOwner: MOCK_REPO.owner,
+                    repoName: MOCK_REPO.name,
+                    repoCurrentBranch: MOCK_REPO.currentBranch,
+                    repoBranchBase: MOCK_REPO.branchBase,
+                    commitSha: MOCK_REPO.branchBase,
                 },
-            ],
-            ci: {
-                githubAccessToken: MOCK_AUTH_TOKEN,
-                repoOwner: MOCK_REPO.owner,
-                repoName: MOCK_REPO.name,
-                repoCurrentBranch: MOCK_REPO.currentBranch,
-                repoBranchBase: MOCK_REPO.branchBase,
-                commitSha: MOCK_REPO.branchBase,
             },
-        })
+
+            {
+                error: () => {},
+                pass: () => {},
+                fail: () => {},
+            },
+        )
 
         delete result.url
         expect(result).toMatchSnapshot()
@@ -88,32 +110,47 @@ describe(`bundlewatch Node API`, () => {
     it('Throws validations error when using brotli compression without the package', async () => {
         let error
         try {
-            await bundlewatchApi({
-                files: [
-                    {
-                        path: './__testdata__/*.jpg',
-                        maxSize: '100kB',
-                    },
-                ],
-                defaultCompression: 'brotli',
-            })
+            await bundlewatchApi(
+                {
+                    files: [
+                        {
+                            path: './__testdata__/*.jpg',
+                            maxSize: '100kB',
+                        },
+                    ],
+                    defaultCompression: 'brotli',
+                },
+
+                {
+                    error: () => {},
+                    pass: () => {},
+                    fail: () => {},
+                },
+            )
         } catch (e) {
             error = e
         }
         expect(error).toMatchSnapshot()
     })
 
     it('Normalizes hash when given a normalizeFilenames option', async () => {
-        const result = await bundlewatchApi({
-            files: [
-                {
-                    path: './__testdata__/*.js',
-                    maxSize: '100kB',
-                },
-            ],
-            defaultCompression: 'none',
-            normalizeFilenames: '^.+?(\\.\\w+)\\.(?:js|css)$',
-        })
+        const result = await bundlewatchApi(
+            {
+                files: [
+                    {
+                        path: './__testdata__/*.js',
+                        maxSize: '100kB',
+                    },
+                ],
+                defaultCompression: 'none',
+                normalizeFilenames: '^.+?(\\.\\w+)\\.(?:js|css)$',
+            },
+            {
+                error: () => {},
+                pass: () => {},
+                fail: () => {},
+            },
+        )
 
         delete result.url
         expect(result.fullResults[0].filePath).toMatchInlineSnapshot(

diff --git a/src/bin/index.js b/src/bin/index.js
@@ -107,15 +107,14 @@ const mainSafe = async () => {
     try {
         const errorCode = await Promise.race([
             main(githubService),
-            (async () => {
-                await new Promise((resolve) => {
-                    if (config.maxTimeout != null) {
-                        setTimeout(resolve, config.maxTimeout)
-                    }
-                    // hang forever if maxTimeout is set to null
-                })
+            new Promise((resolve) => {
+                if (config.maxTimeout != null) {
+                    setTimeout(resolve, config.maxTimeout)
+                }
+                // hang forever if maxTimeout is set to null
+            }).then(() => {
                 throw new Error('Max timeout exceeded')
-            })(),
+            }),
         ])
         return errorCode
     } catch (error) {