Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending github error status on unhandled errors + Adding max timeout #465

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Sending github error status on unhandled errors + Adding max timeout #465

wants to merge 4 commits into from

Commits on Jan 8, 2024

  1. Moving github service initialization outside of code context that inv… 

    …olves bundlewatch APIs and other opaque side-effects so that we can (hopefully always) fail the action when unhandled errors happen, rather than have it hang forever.
    @bigbizze
    bigbizze committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3a824fb View commit details
    Browse the repository at this point in the history

  2. Awaiting where needed, adding uncaughtException and unhandledRejectio… 

    …n handlers, adding property to github service class for it so we know if it has never responded to github, and if not we can throw an error
    @bigbizze
    bigbizze committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    dcf2bd5 View commit details
    Browse the repository at this point in the history

  3. Adding maxTimeout config option, which forces us to report an error s… 

    …tatus to github when the value for maxTimeout is reached. This also helps prevent the infinite hanging issue.
    @bigbizze
    bigbizze committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d26edad View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Update unit tests

    @bigbizze
    bigbizze committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d272492 View commit details
    Browse the repository at this point in the history