Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract GitHub Actions branch name from GTIHUB_REF #66

Merged
merged 3 commits into from Mar 11, 2020
Merged

Extract GitHub Actions branch name from GTIHUB_REF #66

merged 3 commits into from Mar 11, 2020

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Nov 23, 2019

What kind of change does this PR introduce?

Fixes #65

Did you add tests for your changes?

Yes

Summary

GitHub only provides GITHUB_REF env variable which contains ref, not branch name. Here's the difference between ref and branch name: https://stackoverflow.com/q/1526471

Here's the relates SO question: https://stackoverflow.com/q/58033366

@limonte
Copy link
Contributor Author

limonte commented Nov 23, 2019 •
edited

I don't know why CI is failing, the output is kinda messy :/

@limonte limonte changed the title Extract GitHub Action branch name from GTIHUB_REF Extract GitHub Actions branch name from GTIHUB_REF Nov 23, 2019
@limonte
Copy link
Contributor Author

limonte commented Dec 9, 2019 •
edited

ping @jakebolam @iamogbz @tgrant59

Guys, please tell me that bundlewatch isn't another bundlesize :)

Bundlesize has entered maintenance mode and pull requests are left hanging, so we wanted to reboot the community through creating BundleWatch

GitHub Actions support is the dealbreaker for many devs, you can lure some users from bundlesize: siddharthkp/bundlesize#348

@limonte
Copy link
Contributor Author

limonte commented Dec 19, 2019

please tell me that bundlewatch isn't another bundlesize :)

So it seems :/

@limonte limonte closed this Dec 19, 2019
@iamogbz
Copy link
Member

iamogbz commented Dec 21, 2019

@limonte I'll try and get to all these open PRs and Issues over the break. First need to solve the broken build on master

@iamogbz iamogbz reopened this Dec 21, 2019
@ctavan
Copy link

ctavan commented Feb 10, 2020

@iamogbz @jakebolam @limonte is there anything I could help with to get this one merged and a new release of bundlewatch out so that we can start using it with Github actions?

@limonte
Copy link
Contributor Author

limonte commented Mar 9, 2020 •
edited

Guys, reviewing and merging this PR will literally take max 30 min. If you can't dedicate that amount of time for this project, consider archiving it.

When you archive a repository, you are letting people know that a project is no longer actively maintained.

You can archive a repository to make it read-only for all users and indicate that it's no longer actively maintained. You can also unarchive repositories that have been archived.

@iamogbz iamogbz merged commit 5706154 into bundlewatch:master Mar 11, 2020
@limonte limonte mentioned this pull request Mar 11, 2020
Merged
limonte added a commit to sweetalert2/sweetalert2 that referenced this pull request Mar 11, 2020
@limonte
chore: remove not needed anymore for bundlewatch steps (#1915)
6c56577 
bundlewatch/bundlewatch#66 is released in https://github.com/bundlewatch/bundlewatch/releases/tag/v0.2.6
@limonte
Copy link
Contributor Author

limonte commented Mar 11, 2020 •
edited

Better late than never!

Thank you @iamogbz for taking care of things! I tested out the new release in sweetalert2/sweetalert2#1915

All is well 🚀

@jakebolam
Copy link
Member

@limonte @ctavan are you interested in becoming maintainers of the project?

@limonte
Copy link
Contributor Author

limonte commented Mar 12, 2020

nope

ctavan added a commit to uuidjs/uuid that referenced this pull request Mar 12, 2020
@ctavan
chore: upgrade bundlewatch
d0c1192 
bundlewatch/bundlewatch#66 has been merged so we
can now remove manually setting environment variables. bundlewatch will
now pull them automatically for GitHub actions.
@ctavan ctavan mentioned this pull request Mar 12, 2020
Merged
@ctavan
Copy link

ctavan commented Mar 12, 2020

First of all thanks for merging, tried it in uuidjs/uuid#404 and it seems to work well!

I'm happy to supply pull requests for issues I encounter, however I currently won't find enough time to become an active maintainer of this project.

ctavan added a commit to uuidjs/uuid that referenced this pull request Mar 12, 2020
@ctavan
chore: upgrade bundlewatch
47b0431 
bundlewatch/bundlewatch#66 has been merged so we
can now remove manually setting environment variables. bundlewatch will
now pull them automatically for GitHub actions.
ctavan added a commit to uuidjs/uuid that referenced this pull request Mar 12, 2020
@ctavan
chore: upgrade bundlewatch (#404)
d4cf657 
bundlewatch/bundlewatch#66 has been merged so we
can now remove manually setting environment variables. bundlewatch will
now pull them automatically for GitHub actions.
matvejs16 pushed a commit to matvejs16/sweetalert2-fix that referenced this pull request Mar 29, 2023
@limonte
chore: remove not needed anymore for bundlewatch steps (sweetalert2#1915
b36d1c5 
)

bundlewatch/bundlewatch#66 is released in https://github.com/bundlewatch/bundlewatch/releases/tag/v0.2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebolam jakebolam jakebolam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The branch name is detected incorrectly for GitHub Actions
4 participants
@limonte @iamogbz @ctavan @jakebolam