fix AttributeError when reverse-depending on bundle: items

bundlewrap · Jun 8, 2018 · 0c86cdd · 0c86cdd
1 parent 3e2cd3c
commit 0c86cdd
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/bundlewrap/deps.py b/bundlewrap/deps.py
@@ -401,6 +401,9 @@ def add_dep(item, dep):
             if depending_item_id.startswith("bundle:"):
                 depending_bundle_name = depending_item_id.split(":")[1]
                 for depending_item in items.values():
+                    if isinstance(depending_item, DummyItem):
+                        # Type and TagItems don't have bundles
+                        continue
                     if depending_item.bundle.name == depending_bundle_name:
                         add_dep(depending_item, item.id)
 

diff --git a/tests/integration/bw_test.py b/tests/integration/bw_test.py
@@ -635,3 +635,34 @@ def test_secret_identifier_twice(tmpdir):
     assert run("bw test -s ''", path=str(tmpdir))[2] == 0
     assert run("bw test -s 'test'", path=str(tmpdir))[2] == 0
     assert run("bw test -s 'test,foo'", path=str(tmpdir))[2] == 0
+
+
+def test_reverse_dummy_dep(tmpdir):
+    make_repo(
+        tmpdir,
+        nodes={
+            "node1": {
+                'bundles': ["bundle1", "bundle2"],
+            },
+        },
+        bundles={
+            "bundle1": {
+                'files': {
+                    "/test": {
+                        'content': "test",
+                    },
+                },
+            },
+            "bundle2": {
+                'files': {
+                    "/test2": {
+                        'content': "test",
+                        'needed_by': ["bundle:bundle1"],
+                    },
+                },
+            },
+        },
+    )
+
+    stdout, stderr, rcode = run("bw test", path=str(tmpdir))
+    assert rcode == 0