better error message for non-dict items

bundlewrap · Sep 10, 2017 · 895f493 · 895f493
1 parent dc6f15e
commit 895f493
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/bundlewrap/items/__init__.py b/bundlewrap/items/__init__.py
@@ -315,6 +315,13 @@ def _test(self):
 
     @classmethod
     def _validate_attribute_names(cls, bundle, item_id, attributes):
+        if not isinstance(attributes, dict):
+            raise BundleError(_(
+                "invalid item '{item}' in bundle '{bundle}': not a dict"
+            ).format(
+                item=item_id,
+                bundle=bundle.name,
+            ))
         invalid_attributes = set(attributes.keys()).difference(
             set(cls.ITEM_ATTRIBUTES.keys()).union(
                 set(BUILTIN_ITEM_ATTRIBUTES.keys())