Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate item definition if two bundles need the same {apt,pacman,pip}-package #396

Open
dstengele opened this issue Mar 31, 2018 · 3 comments
Milestone

Comments

@dstengele
Copy link
Contributor

If two bundles require the same apt (or any other) package and the respective pkg_apt items are added to the bundles, bw throws a BundleError with "duplicate definition". While this is useful to make sure no two bundles define different attributes for files or directories, I don't see the point in throwing the Error when both items' definitions are exactly the same. This will probably be the case with dependencies to packages, as they are usually just installed without any other metadata.

Am I just getting the wrong idea here and there is a better approach to such situations? Or should I create a dedicated bundle with only the apt_pkg dependency that both bundles should depend on?

DasLampe pushed a commit to DasLampe/bundlewrap that referenced this issue Oct 29, 2018
@rhazdon
Copy link

rhazdon commented Jan 6, 2019

Hey @DasLampe, would you like to open a pull request with your solution? :)

@DasLampe
Copy link

Yes, will create pull request in the next days.
Must rewrite some code and/or create pull request for #408

@DasLampe
Copy link

See PR #416

@trehn trehn added this to the 5.0.0 milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants