bw metadata: Don’t resolve Faults by default
#758
Conversation
| @@ -117,6 +117,15 @@ def __init__(self, fault_identifier, callback, **kwargs): | |||
| self.callback = callback | |||
| self.kwargs = kwargs | |||
|
|
|||
| def _repr_first(self): | |||
| if isinstance(self.id_list, list): | |||
| return f"<Fault: {self.id_list[0]}>" | |||
There was a problem hiding this comment.
I'm not 100% sold on this. If a secret is formatted into something else, i would like to know that. On the other hand, id_list might get very long, and we don't want to clutter the whole screen?
There was a problem hiding this comment.
It can get very long, see reasoning here: https://github.com/bundlewrap/bundlewrap/pull/758/files#diff-58547683697529b0873aa6b387d16f0fefc4e1430e101f8d54198336b62a7b31R305-R312
The usual __repr__() does this:
While _repr_first() does this:
There was a problem hiding this comment.
… I just had a use case where the full list would have been helpful. Need to think about this.
--unresolved-faults-full would do the trick, but feels quite clunky. 🫤
There was a problem hiding this comment.
I suggest merging this as is. --unresolved-faults-full is probably very rare. Let’s see how often we actually need that.
This implements #557.