Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing id field from mastercard action. (bunq/sdk_csharp#52) #74

Merged

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Dec 30, 2017

Closes #52

@OGKevin OGKevin added this to the 0.12.5 milestone Dec 30, 2017
@OGKevin OGKevin self-assigned this Dec 30, 2017
@OGKevin
Copy link
Contributor Author

OGKevin commented Jan 2, 2018

@epels mostly generated code but still please 👀

@@ -195,6 +201,11 @@ public static BunqResponse<List<MasterCardAction>> List(ApiContext apiContext, i
/// </summary>
public override bool IsAllFieldNull()
{
if (this.Id != null)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.Id.HasValue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code, please create follow up issue as this requires changes in the generator it self.

@OGKevin
Copy link
Contributor Author

OGKevin commented Jan 2, 2018

@andrederoos all yours please 👀

@OGKevin OGKevin assigned andrederoos and unassigned epels Jan 2, 2018
@OGKevin OGKevin force-pushed the bunq/sdk_csharp#52-fix-missing-mastercard-action-id branch from 1827868 to a96e010 Compare January 2, 2018 11:14
@bunq bunq deleted a comment Jan 2, 2018
@bunq bunq deleted a comment Jan 2, 2018
@andrederoos andrederoos changed the title Added missing id field from masgtercard action. (bunq/sdk_csharp#52) Added missing id field from mastercard action. (bunq/sdk_csharp#52) Jan 2, 2018
@andrederoos andrederoos merged commit 45a7690 into develop Jan 2, 2018
@andrederoos andrederoos deleted the bunq/sdk_csharp#52-fix-missing-mastercard-action-id branch January 2, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants