Added assertions to tests missing it. (#120)

bunq · Apr 5, 2018 · 36529a3 · 36529a3
1 parent 960a884
commit 36529a3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 8 deletions.
diff --git a/tests/Model/Generated/Endpoint/PaymentTest.php b/tests/Model/Generated/Endpoint/PaymentTest.php
@@ -48,27 +48,33 @@ public function testSendMoneyToOtherUser()
     {
         $this->skipTestIfNeededDueToInsufficientBalance();
 
-        Payment::create(
+        $response = Payment::create(
             new Amount(self::PAYMENT_AMOUNT_IN_EUR, self::PAYMENT_CURRENCY),
             $this->getPointerUserBravo(),
             self::PAYMENT_DESCRIPTION
         );
+
+        static::assertNotNull($response);
     }
 
     /**
      * Test sending money to other monetaryAccount.
      *
      * This test has no assertion as of its testing to see if the code runs without errors.
      */
-    public function testSendMoneyToOtherMonetaryAccount()
+    public function testSendMoneyToOtherMonetaryAccount(): BunqResponseInt
     {
         $this->skipTestIfNeededDueToInsufficientBalance();
 
         $paymentId = Payment::create(
             new Amount(self::PAYMENT_AMOUNT_IN_EUR, self::PAYMENT_CURRENCY),
             $this->getSecondMonetaryAccountAlias(),
             self::PAYMENT_DESCRIPTION
-        )->getValue();
+        );
+
+        static::assertNotNull($paymentId);
+
+        return $paymentId;
     }
 
     /**
@@ -78,12 +84,14 @@ public function testSendMoneyToOtherMonetaryAccount()
      *
      * @depends testSendMoneyToOtherMonetaryAccount
      */
-    public function testSendMessageToPayment()
+    public function testSendMessageToPayment(BunqResponseInt $paymentId)
     {
         $chatId = PaymentChat::create(
-            $this->paymentId
+            $paymentId->getValue()
         )->getValue();
 
-        ChatMessageText::create($chatId, self::PAYMENT_CHAT_TEXT_MESSAGE);
+        $response = ChatMessageText::create($chatId, self::PAYMENT_CHAT_TEXT_MESSAGE);
+
+        static::assertNotNull($response);
     }
 }
diff --git a/tests/Model/Generated/Endpoint/RequestInquiryTest.php b/tests/Model/Generated/Endpoint/RequestInquiryTest.php
@@ -45,6 +45,9 @@ public function testSendingAndAcceptingRequest()
 
         $this->sendRequest();
         $responses = RequestResponse::listing($this->getSecondMonetaryAccountId())->getValue();
+
+        static::assertNotNull($responses);
+
         $requestResponseId = $responses[self::INDEX_FIRST]->getId();
         $this->acceptRequest($requestResponseId);
     }
@@ -53,24 +56,28 @@ public function testSendingAndAcceptingRequest()
      */
     private function sendRequest()
     {
-        RequestInquiry::create(
+        $response = RequestInquiry::create(
             new Amount(self::REQUEST_AMOUNT_IN_EUR, self::REQUEST_CURRENCY),
             $this->getSecondMonetaryAccountAlias(),
             self::REQUEST_DESCRIPTION,
             false
         );
+
+        static::assertNotNull($response);
     }
 
     /**
      * @param int $requestResponseId
      */
     private function acceptRequest(int $requestResponseId)
     {
-        RequestResponse::update(
+        $response = RequestResponse::update(
             $requestResponseId,
             $this->getSecondMonetaryAccountId(),
             null,
             self::REQUEST_STATUS_ACCEPTED
         );
+
+        static::assertNotNull($response);
     }
 }