Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] Revamp readme #139

Closed
OGKevin opened this issue Apr 8, 2018 · 4 comments
Closed

[epic] Revamp readme #139

OGKevin opened this issue Apr 8, 2018 · 4 comments
Assignees

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Apr 8, 2018

Whit the release of tinker, we will now use that as example. So example references to the example folder should be pointed to tinker code.

@OGKevin OGKevin added this to the 0.13.5 milestone Apr 8, 2018
@OGKevin OGKevin self-assigned this Apr 8, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 8, 2018

do-not-edit-start-codetree-epic-issues

Issues in this epic:

Title Milestone Assignees Stage State
[php] Update examples in readme #140 1.0.0 OGKevin Closed
[csharp] Update examples in readme #91 1.0.0 OGKevin Closed
[python] Update examples in readme #87 0.13.5 OGKevin Closed
[Java] Update examples in readme #81 1.0.0 OGKevin Closed
do-not-edit-end-codetree-epic-issues

@OGKevin OGKevin removed this from the 0.13.5 milestone Apr 8, 2018
@OGKevin OGKevin changed the title Revamp readme [epic] Revamp readme Apr 8, 2018
@Wouter0100
Copy link

Wouter0100 commented Jun 7, 2018

Listing monetary accounts example does not seem to work. Corrected one:

$monetaryAccountList = MonetaryAccount::listing();

foreach ($monetaryAccountList->getValue() as $monetaryAccount) {
    var_dump($monetaryAccount->getReferencedObject()->getDescription() . PHP_EOL);
}
``

@OGKevin
Copy link
Contributor Author

OGKevin commented Jun 7, 2018

@Wouter0100 😁 nice stop, feel free to create a PR to fix this :). Do you mind checking the readme's of the other 2 SDK's and create a PR ? They are referenced in the comment above.

@Wouter0100
Copy link

Sure! @OGKevin I'll get back to you asap when I have a complete overview and implemented the features I need :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants