Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[php] Update examples in readme #140

Closed
OGKevin opened this issue Apr 8, 2018 · 0 comments
Closed

[php] Update examples in readme #140

OGKevin opened this issue Apr 8, 2018 · 0 comments
Assignees
@OGKevin
Labels
enhancement
Projects
1.0.0 - SDK
Milestone
1.0.0

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Apr 8, 2018

Steps to reproduce:

  1. Take a look the readme

What should happen:

  1. The examples are accurate and references to tinker.

What happens:

  1. Examples is outdated
@OGKevin OGKevin added this to the 0.13.5 milestone Apr 8, 2018
@OGKevin OGKevin self-assigned this Apr 8, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Apr 8, 2018
@OGKevin OGKevin mentioned this issue Apr 8, 2018
Closed
@OGKevin OGKevin changed the title Update examples in readme Update examples in readme php Apr 8, 2018
@OGKevin OGKevin changed the title Update examples in readme php [php] Update examples in readme Apr 8, 2018
OGKevin added a commit that referenced this issue Apr 9, 2018
@OGKevin
Update readme to point to tinker. (#140)
6ddf113
@OGKevin OGKevin mentioned this issue Apr 9, 2018
Merged
@OGKevin OGKevin moved this from To do to pending review in 1.0.0 - SDK Apr 9, 2018
OGKevin added a commit that referenced this issue Apr 10, 2018
@OGKevin
Fixed code formatting. (#140)
3941c4a
OGKevin added a commit that referenced this issue Apr 10, 2018
@OGKevin
Fixed some text formatting. (#140)
7763b06
OGKevin added a commit that referenced this issue Apr 10, 2018
@OGKevin
Added missing syntax. (#140)
13b22fc
OGKevin added a commit that referenced this issue Apr 10, 2018
@OGKevin
Named MonetaryAccount properly. (#140)
50f8cf3
OGKevin added a commit that referenced this issue Apr 10, 2018
@OGKevin
Merge pull request #142 from bunq/update_read_me_bunq/sdk_php#140
a9b71a2 
Update readme to point to tinker. (#140)
@OGKevin OGKevin closed this as completed Apr 10, 2018
1.0.0 - SDK automation moved this from pending review to Done Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
No open projects
1.0.0 - SDK
  
Done
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@OGKevin