Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove phpstan #28

Closed
qurben opened this issue Aug 7, 2017 · 2 comments
Closed

Remove phpstan #28

qurben opened this issue Aug 7, 2017 · 2 comments
Assignees
@qurben
Labels
enhancement

Comments

@qurben
Copy link
Contributor

qurben commented Aug 7, 2017

Phpstan does not support PHP 5.6, we do. Therefore it is not possible for us to use it.
@qurben qurben self-assigned this Aug 7, 2017
qurben pushed a commit that referenced this issue Aug 7, 2017
#28 remove phpstan as it does not support php 5.6
77333cc
qurben pushed a commit that referenced this issue Aug 7, 2017
#28 remove phpstan as it does not support php 5.6
0bf55bb
@qurben qurben mentioned this issue Aug 7, 2017
Merged
dnl-blkv added a commit that referenced this issue Aug 7, 2017
@dnl-blkv
Merge pull request #29 from bunq/28-remove-phpstan
fe15dd2 
#28 remove phpstan as it does not support php 5.6
@holtkamp
Copy link
Contributor

holtkamp commented Sep 7, 2017

Apparently PHP 5.6 support is dropped, so PHPStan can be re-enabled?

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Sep 7, 2017

@holtkamp yes, we can make use of it now! Please re-add it if you could :)
Otherwise, we can include it in the next patch ourselves.

@holtkamp holtkamp mentioned this issue Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qurben qurben

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@qurben @holtkamp @dnl-blkv @OGKevin