Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End support for PHP 5.6 #44

Closed
dnl-blkv opened this issue Sep 4, 2017 · 1 comment
Closed

End support for PHP 5.6 #44

dnl-blkv opened this issue Sep 4, 2017 · 1 comment
Assignees
Milestone

Comments

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Sep 4, 2017

How to Reproduce

  1. Try composer install with PHP 5.6 for the SDK

What Should Happen

  1. composer install fails, because PHP 5.6 is not supported

What Happens

  1. composer install succeeds
  2. Examples/tests fail due to a PHP 5.6-specific bug

Notes

  1. The SDK was not working with PHP 5.6 for some time, but the question was only raised once, and the questioning person was OK with switching to PHP 7.0
  2. Therefore, in order to be sure we provide best possible SDK for PHP 7.0+, and to contribute to the migration of developers to PHP 7.0 we would like to end support of PHP 5.6
  3. This would mean changes to the code style, such as adding scalar parameter and return type-hints or using other language features introduced in PHP 7.0
@dnl-blkv dnl-blkv self-assigned this Sep 4, 2017
@OGKevin OGKevin added this to the v0.11.0 milestone Sep 5, 2017
@OGKevin
Copy link
Contributor

OGKevin commented Sep 7, 2017

Closing in favor of #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants