-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination and limit is missing for listing methods #15
Comments
Hey @georgeboot, This is indeed right, pagination support is not added yet and will be added soon 👍 |
@OGKevin Any update on this? Without this the SDK is completely unusable for any purpose whatsoever |
@kenloburn pagination functionality requires a response object, which is coming with the update 0.10.0 scheduled for today. Pagination support will be added in 0.10.1 |
@dnl-blkv tbh if you're using semver for your library versioning it doesn't make sense to introduce relatively big new functionality in a patch version - 0.11.0 seems more appropriate in this case |
@kenloburn that makes sense, we can do 0.11.0 for this :) |
@kenloburn It is coming in 0.11.0 next Tuesday :) |
@kenloburn I would like to know why you think the SDK is useless without pagination 🤔 |
@OGKevin I'd like to retrieve more than 10 transactions 😁 |
It would be nice if bunq would return the total number of records so we can calculate the total number of pages.. |
@BabyDino Good point, we'll consider this feature! |
Add Pagination and missing fields/endpoints [#15]
For all
listing
methods, there is no pagination.This means
x
items from the resource.This could be resolved by a complete implementation of the pagination as documented here.
The text was updated successfully, but these errors were encountered: