Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination and limit is missing for listing methods #15

Closed
georgeboot opened this issue Aug 4, 2017 · 12 comments
Closed

Pagination and limit is missing for listing methods #15

georgeboot opened this issue Aug 4, 2017 · 12 comments
Milestone

Comments

@georgeboot
Copy link

georgeboot commented Aug 4, 2017

For all listing methods, there is no pagination.

This means

  • You can only retrieve the first 10 items;
  • This limit of 10 items is not customisable;
  • There is no way of getting the next batch of x items from the resource.

This could be resolved by a complete implementation of the pagination as documented here.

@OGKevin
Copy link
Contributor

OGKevin commented Aug 4, 2017

Hey @georgeboot,

This is indeed right, pagination support is not added yet and will be added soon 👍

@kenloburn
Copy link

@OGKevin Any update on this? Without this the SDK is completely unusable for any purpose whatsoever

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 22, 2017

@kenloburn pagination functionality requires a response object, which is coming with the update 0.10.0 scheduled for today.

Pagination support will be added in 0.10.1

@kenloburn
Copy link

@dnl-blkv tbh if you're using semver for your library versioning it doesn't make sense to introduce relatively big new functionality in a patch version - 0.11.0 seems more appropriate in this case

@dnl-blkv
Copy link
Contributor

@kenloburn that makes sense, we can do 0.11.0 for this :)
Thanks!

@OGKevin OGKevin added this to the v0.11.0 milestone Aug 22, 2017
@kenloburn
Copy link

@dnl-blkv @OGKevin Any update on this? The SDK without this is still completely unusable

@dnl-blkv
Copy link
Contributor

@kenloburn It is coming in 0.11.0 next Tuesday :)

@OGKevin
Copy link
Contributor

OGKevin commented Aug 31, 2017

@kenloburn I would like to know why you think the SDK is useless without pagination 🤔

@kenloburn
Copy link

@OGKevin I'd like to retrieve more than 10 transactions 😁

@BabyDino
Copy link
Contributor

It would be nice if bunq would return the total number of records so we can calculate the total number of pages..

@dnl-blkv
Copy link
Contributor

@BabyDino Good point, we'll consider this feature!

dnl-blkv added a commit that referenced this issue Sep 1, 2017
dnl-blkv added a commit that referenced this issue Sep 1, 2017
dnl-blkv added a commit that referenced this issue Sep 3, 2017
dnl-blkv added a commit that referenced this issue Sep 3, 2017
dnl-blkv added a commit that referenced this issue Sep 3, 2017
dnl-blkv added a commit that referenced this issue Sep 5, 2017
dnl-blkv added a commit that referenced this issue Sep 6, 2017
dnl-blkv added a commit that referenced this issue Sep 6, 2017
dnl-blkv added a commit that referenced this issue Sep 6, 2017
dnl-blkv added a commit that referenced this issue Sep 6, 2017
dnl-blkv added a commit that referenced this issue Sep 6, 2017
andrederoos added a commit that referenced this issue Sep 6, 2017
Add Pagination and missing fields/endpoints [#15]
@OGKevin
Copy link
Contributor

OGKevin commented Sep 6, 2017

@georgeboot @kenloburn @BabyDino FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants