Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure Guzzle options / use a proxy to ensure static IP address #5

Closed
holtkamp opened this issue Aug 2, 2017 · 4 comments
Assignees

Comments

@holtkamp
Copy link
Contributor

holtkamp commented Aug 2, 2017

The Bunq API expects requests to be initiated from a fixed / whitelisted IP address, which is difficult in a "cloud" environment, with ever changing IP addresses.

A proxy can circumvent this problem and ensure a fixed IP address is used. However the current initialisation of the Guzzle client does not allow to set the proxy option.

Also see this issue which discusses a similar situation: link0/bunq#27

@holtkamp holtkamp changed the title Support for a proxy Allow to configure Guzzle options / use a proxy to ensure static IP address Aug 2, 2017
qurben pushed a commit that referenced this issue Aug 7, 2017
qurben pushed a commit that referenced this issue Aug 7, 2017
qurben pushed a commit that referenced this issue Aug 7, 2017
qurben pushed a commit that referenced this issue Aug 7, 2017
qurben pushed a commit that referenced this issue Aug 7, 2017
dnl-blkv added a commit that referenced this issue Aug 10, 2017
@OGKevin
Copy link
Contributor

OGKevin commented Aug 10, 2017

@holtkamp FYI

@holtkamp
Copy link
Contributor Author

holtkamp commented Aug 10, 2017

Nice! Minor doubt: why only "allow" a string? Guzzle itself also allows an array. Currently the type is not enforced, but the docs suggest it must be a string...

Also see: http://docs.guzzlephp.org/en/stable/request-options.html#proxy

@qurben
Copy link
Contributor

qurben commented Aug 10, 2017

@holtkamp, there is no use case for using an array at the moment. All requests will be to the same server and over https. So unless there is some hidden option in the proxy array it is useful for this SDK.

While it is true that setting a proxy to an array is allowed, it will break your context object.

@holtkamp
Copy link
Contributor Author

ok, thanks for the explanation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants