Monetary account joint cannot be retrieved.

[OGKevin]

Steps to reproduce:

1. Create a new joint account
2. try something like MonetaryAccount.list

What should happen:

1. Monetary account joints are also listed

What happens:

1. you will get all accounts except the new joint accounts

Logs

• Logs no logs

Extra info:

• Tested on 0.12.3

[JanMisker]

The joint accounts are returned in the response, but a call to MonetaryAccount::listing() now fails, I think because in the MonetaryAccountJoint in the response the property all_co_owner with the co-owners is not properly mapped to the CoOwner model.

Background: debugging I found that the MonetaryAccountJoint looks very much like the MonetaryAccountBank, except for the addition of the all_co_owner property, which is an object with two properties: alias (user object for the co-owner) and status. Somehow this isn't picked up properly, maybe because in CoOwner.php the declaration of $alias has@var LabelUser[] instead of @var LabelUser (although that last also didn't work when I quickly tried it).

[OGKevin]

Interesting, if its not mapped/populated with data then there is indeed a definition error. The response contains data or the data is structured in some way that the SDK does not know what to do with it. To actually write a test case for this will be hard as creating a joint account requires 2 users 🤔.

So the way I could test this is to get my hands on a raw monetary account joint response and map it to the model and ensure the fields are set.

@JanMisker thanks for reporting.

[JanMisker]

I should have been more clear, there is now a Fatal error on the listing call, it's not just the all_co_owner field that doesn't get populated.

Fatal error: Uncaught TypeError: Argument 1 passed to bunq\Model\Core\BunqModel::createFromResponseArray() must be of the type array, string given, called in /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php on line 236 and defined in /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php on line 97

Call Stack:

    0.1188     379760   1. {main}() /MYPATH/test.php:0
    1.8088    2383488   2. bunq\Model\Generated\Endpoint\MonetaryAccount::listing(???, ???) /MYPATH/test.php:111
    8.1000    2419968   3. bunq\Model\Core\BunqModel::fromJsonList(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Generated/Endpoint/MonetaryAccount.php:100
    8.1007    2495224   4. bunq\Model\Core\BunqModel::createListFromResponseArray(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:296
    8.1111    2498968   5. bunq\Model\Core\BunqModel::createFromResponseArray(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:236
    8.1111    2498968   6. bunq\Model\Core\BunqModel::createFromResponseArrayAnchorObject(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:102
    8.1111    2498968   7. bunq\Model\Core\BunqModel::createInstanceFromResponseArray(???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:134
    8.1112    2499440   8. bunq\Model\Core\BunqModel::determineFieldContents(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:159
    8.1131    2542304   9. bunq\Model\Core\BunqModel::createFromResponseArray(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:206
    8.1131    2542304  10. bunq\Model\Core\BunqModel::createInstanceFromResponseArray(???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:113
    8.1215    2544584  11. bunq\Model\Core\BunqModel::determineFieldContents(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:159
   15.0952    2553800  12. bunq\Model\Core\BunqModel::createListFromResponseArray(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:201
   15.0954    2553800  13. bunq\Model\Core\BunqModel::createFromResponseArray(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:236
   15.0954    2553800  14. bunq\Model\Core\BunqModel::createInstanceFromResponseArray(???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:113
   15.0957    2554224  15. bunq\Model\Core\BunqModel::determineFieldContents(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:159
   16.0959    2569968  16. bunq\Model\Core\BunqModel::createListFromResponseArray(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:201
   16.0962    2569968  17. bunq\Model\Core\BunqModel::createFromResponseArray(???, ???) /MYPATH/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:236

[JanMisker]

Found it, in

sdk_php/src/Model/Generated/Object/CoOwner.php

Line 14 in 652e650

* @var LabelUser[]

Replace
* @var LabelUser[]
with
* @var LabelUser
and it works.

But this is generated code, so probably needs to be changed elsewhere, but for my purposes it works now.

[OGKevin]

@JanMisker thanks for reporting, debugging and finding the solution!

This is indeed generated code and has te be changed on our side. As its a miss definition, it should be an ez fix. I will take it over from here.