Token qr request ideal returns the wrong type. (bunq/sdk_php#80) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandervdo please 👀 |
sandervdo
suggested changes
Jan 16, 2018
| @@ -34,7 +34,8 @@ class Avatar extends BunqModel | |||
| /** | |||
| * Object type. | |||
| */ | |||
| const OBJECT_TYPE = 'Avatar'; | |||
| const OBJECT_TYPE_POST ='Uuid'; | |||
There was a problem hiding this comment.
No space after =, while it used to be there. Check the generator?
|
@sandervdo please have another 👀 |
|
That looks better. 👍 |
sandervdo
previously approved these changes
Jan 16, 2018
OGKevin
force-pushed
the
bunq/sdk_php#80_TokenQrRequestIdeal_returns_the_wrong_type
branch
from
932b7ee
to
5376e06
Compare
|
ack, thx @sandervdo |
sandervdo
approved these changes
Jan 17, 2018
andrederoos
approved these changes
Jan 17, 2018
andrederoos
deleted the
bunq/sdk_php#80_TokenQrRequestIdeal_returns_the_wrong_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues: