Removed unneeded doc block. (bunq/sdk_php#80) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandervdo
reviewed
Feb 2, 2018
| if (!is_null($this->bunqMeTabId)) { | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
You can make this one if/elseif/else.
There was a problem hiding this comment.
Thats hard to generate as it requires some good logic to know when to stop the else if chain and do else. This was a fast and easy solution. Will keep this as �improvement.
There was a problem hiding this comment.
Ah right,.. it is generated code. 😅 Would be better to review the generator and have proper tests for it than reviewing the generated code itself imho.
There was a problem hiding this comment.
The generator is ofc also review 😝 but its not open source 😉
sandervdo
approved these changes
Feb 2, 2018
andrederoos
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues: