Optimise test framework bunq/sdk_php#120 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
changed the title
OGKevin
commented
Apr 2, 2018
tests/BunqSdkTestBase.php
Outdated
| ] | ||
| ); | ||
| $avatarUuid = Avatar::create($attachmentUuid->getValue()); | ||
|
|
| @@ -8,6 +8,7 @@ | |||
| use bunq\Model\Generated\Object\Pointer; | |||
| use bunq\test\BunqSdkTestBase; | |||
| use bunq\test\Config; | |||
| use phpDocumentor\Reflection\Types\This; | |||
|
@sandervdo please 👀 |
sandervdo
reviewed
Apr 3, 2018
tests/BunqSdkTestBase.php
Outdated
| ] | ||
| ); | ||
| $avatarUuid = Avatar::create($attachmentUuid->getValue()); | ||
| $cashId = CashRegister::create( |
| foreach ($allAlias as $alias) { | ||
| if ($alias->getType() === self::POINTER_TYPE_IBAN) { | ||
| return $alias; | ||
| } |
There was a problem hiding this comment.
In open-source project explicit else is not needed. Only in bunq internal projects.
tests/BunqSdkTestBase.php
Outdated
| */ | ||
| protected static function createApiContext(): ApiContext | ||
| protected function getUserBravoPointer(): Pointer |
tests/BunqSdkTestBase.php
Outdated
| /** | ||
| * @return bool | ||
| */ | ||
| protected function doesAccountHaveEnoughMoney(): bool |
There was a problem hiding this comment.
isMonetaryAccountBalanceSufficient
tests/BunqSdkTestBase.php
Outdated
| { | ||
| if (!$this->doesAccountHaveEnoughMoney()) { | ||
| static::markTestSkipped(self::WARMING_TEST_SKIPPED_DUE_TO_INSUFFICIENT_BALANCE); | ||
| } |
There was a problem hiding this comment.
In open-source project explicit else is not needed. Only in bunq internal projects.
| { | ||
| $this->assertTestShouldBeSkippedDueToInsufficientBalance(); |
There was a problem hiding this comment.
Naming seems weird. Asserting the test should be skipped?
| /** | ||
| * Tests the creation of a tab. | ||
| * | ||
| * This test and all its dependants have no assertion as of its testing to see if the code runs without errors. | ||
| */ | ||
| public function testCreateTab() | ||
| { | ||
| if (BunqContext::getUserContext()->isOnlyUserPersonSet()) { | ||
| static::markTestSkipped('Only user company can create tabs.'); | ||
| } |
There was a problem hiding this comment.
In open-source project explicit else is not needed. Only in bunq internal projects.
There was a problem hiding this comment.
Ack, man, this switching between style guides... 😅
|
@sandervdo please 👀 again. |
sandervdo
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues: