Fix supperflous fields error bunq/sdk_php#118 #125
Conversation
OGKevin
changed the title
| use bunq\test\BunqSdkTestBase; | ||
|
|
||
| /** | ||
| * @author Kevin Hellemun <khellemun@bunq.com> |
There was a problem hiding this comment.
This header can be removed.
| use bunq\test\BunqSdkTestBase; | ||
|
|
||
| /** | ||
| * @author Kevin Hellemun <khellemun@bunq.com> |
There was a problem hiding this comment.
header can be removed.
src/Model/Core/BunqModel.php
Outdated
| const FORMAT_STRING_EMPTY = ''; | ||
| const SUFFIX_REQUEST_FIELD = '_field_for_request'; | ||
|
|
||
|
|
| use bunq\Model\Generated\Object\Pointer; | ||
| use bunq\test\BunqSdkTestBase; | ||
|
|
||
| /** |
There was a problem hiding this comment.
This is so ugly. Why don't we leave it out when we don't adhere strictly to internal codestyle guidelines anyway?
| * Test constants | ||
| */ | ||
| const PAYMENT_CURRENCY = 'EUR'; | ||
| const PAYMENT_DESCRIPTION = "php sdk Batch test"; |
There was a problem hiding this comment.
Single quotes rather than double qoutes.
| */ | ||
| public function testSendBatchPayment() | ||
| { | ||
| $response = PaymentBatch::create( |
| { | ||
| $allPayment = []; | ||
|
|
||
| while (count($allPayment) < 10) { |
| @@ -45,4 +35,14 @@ public static function tearDownAfterClass() | |||
| BunqContext::getApiContext()->resetSession(); | |||
| BunqContext::getApiContext()->save(self::FILE_PATH_CONTEXT_CONFIG); | |||
| } | |||
|
|
|||
| /** | |||
| * Delete's the current session. | |||
| /** | ||
| * Delete's the current session. | ||
| * | ||
| * This test has no assertion as of its testing to see if the code runs without errors. |
There was a problem hiding this comment.
as it is testing whether the code runs without errors.
Same typo as in other PR. Generated/copied error?
There was a problem hiding this comment.
Nah, back in the day when we were using the old PhpUnit you could leave tests without assertions hence the message in the test header. Since #96 it will say risky tests if no assertions where added. But I seem to forgot to remove these comments 🤦♂️
OGKevin
changed the title
This PR closes/fixes the following issues:
must be merged after #124