Auto update bunq context bunq/sdk_php#94 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandervdo
reviewed
Apr 9, 2018
tests/Context/ApiContextTest.php
Outdated
| static::assertTrue($validApiContext->ensureSessionActive()); | ||
| static::assertNotEquals($expiredApiContext, $validApiContext); | ||
|
|
||
| BunqContext::updateApiContext(clone $expiredApiContext); |
There was a problem hiding this comment.
Why cloning here again @OGKevin ?
There was a problem hiding this comment.
@OGKevin removed the asserts intentionally? The one on session state can remain right?
There was a problem hiding this comment.
Yes because it is triggered deeper in the code as well. So, if a do the assertion on the ensure update method. It will actually update the context. The purpose of this test is to see if the ApiClient indeed updates the context it self and assigns it to BunqContext. So I basically was updating the context instead of ApiClient doing it 🤦♂️
|
@sandervdo pushed, please 👀 |
sandervdo
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #94