Assert values are correct for api context bunq/sdk_php#35 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandervdo
previously requested changes
Apr 9, 2018
src/Context/ApiContext.php
Outdated
| @@ -104,6 +105,9 @@ public static function create( | |||
| array $permittedIps = [], | |||
| string $proxyUrl = null | |||
| ): ApiContext { | |||
| InstallationUtil::assertDeviceDescriptionIsValid($description); | |||
| InstallationUtil::assertAllIpIsValid($permittedIps); | |||
There was a problem hiding this comment.
Plural in $permittedIps -> $allPermittedIp
src/Util/InstallationUtil.php
Outdated
| @@ -23,6 +23,7 @@ | |||
| const ERROR_EMPTY_DESCRIPTION = 'Description cannot be empty.'; | |||
| const ERROR_INVALID_IP_ADDRESS = 'Invalid ip address "%s"'; | |||
| const ERROR_CANNOT_CREATE_API_KEY_PRODUCTION = 'Cannot automatically create API key for production.'; | |||
| const ERROR_INVALID_DEVICE_DESCRIPTION = '"%s" can not be used as a device description.'; | |||
There was a problem hiding this comment.
Can we add a reason here? This error is not really clear.
| * @return bool | ||
| * @throws BunqException | ||
| */ | ||
| public static function assertDeviceDescriptionIsValid(string $deviceDescription): bool |
There was a problem hiding this comment.
I keep forgetting about this,.. do we have typehints for string in SDK?
There was a problem hiding this comment.
Yea, in the SDK we do not suffer from auto casting and therefore we indeed type hint strings.
sandervdo
previously approved these changes
Apr 9, 2018
OGKevin
dismissed
sandervdo’s stale review
Requested changes have not been provided yet.
|
@sandervdo pushed, please 👀 |
OGKevin
deleted the
assert_values_are_correct_for_api_context_bunq/sdk_php#35
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #35