Regenerated code. (bunq/sdk_php#118) #141
Conversation
|
@sandervdo please 👀 |
| * | ||
| * @return RequestInquiryReference[] | ||
| */ | ||
| public function getRequestReferenceSplitTheBill() |
There was a problem hiding this comment.
No return type generated?
There was a problem hiding this comment.
You mean type hint ?
No, once we update the min required php version. As these fields can be null.
There was a problem hiding this comment.
No, return type.. Doc does not specify this function can return null. So which one is wrong?
There was a problem hiding this comment.
Yea I meant return type hint :P. Well the thing is, the generator can not know if these response field will always be present and therefore add |null as the definitions do no define nullable. If not we would need to add |null to all response fields 🤔
There was a problem hiding this comment.
Hmm I see, let's leave it like this then. Sounds like an unnecessary refactor.
| * | ||
| * @param RequestInquiryReference[] $requestReferenceSplitTheBill | ||
| */ | ||
| public function setRequestReferenceSplitTheBill($requestReferenceSplitTheBill) |
References #118