Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerated code to add request fields to objects. (bunq/sdk_php#118) #143

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Regenerated code to add request fields to objects. (bunq/sdk_php#118) #143

merged 1 commit into from
Apr 11, 2018

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Apr 11, 2018

References #118

@OGKevin OGKevin added this to the 0.13.5 milestone Apr 11, 2018
@OGKevin OGKevin self-assigned this Apr 11, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Apr 11, 2018
@OGKevin OGKevin moved this from To do to open PR in 1.0.0 - SDK Apr 11, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 11, 2018

@sandervdo please 👀

@OGKevin OGKevin requested a review from sandervdo April 11, 2018 12:26
sandervdo
sandervdo approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@sandervdo sandervdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @OGKevin

@OGKevin OGKevin merged commit 197e162 into develop Apr 11, 2018
1.0.0 - SDK automation moved this from open PR to merged Apr 11, 2018
@OGKevin OGKevin deleted the add_request_fields_to_objects_bunq/sdk_php#118 branch April 11, 2018 15:57
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 11, 2018

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandervdo sandervdo sandervdo approved these changes

Assignees

@OGKevin OGKevin

Labels
Can be merged
Projects
No open projects
1.0.0 - SDK
  
merged
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OGKevin @sandervdo