Move to new sandbox bunq/sdk_php#149 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandervdo please 👀 |
sandervdo
reviewed
May 29, 2018
src/Http/ApiClient.php
Outdated
| const ERROR_ENVIRONMENT_TYPE_UNKNOWN = 'Unknown environmentType "%s"'; | ||
| const ERROR_MAC_OS_CURL_VERSION = 'Your PHP seems to be linked to the MacOS provided curl binary. ' . | ||
| 'This is incompatible with our SDK, please reinstall by running: "brew reinstall %s --with-homebrew-curl".%s'; | ||
| const ERROR_SANDBOX_DOES_NOT_SUPPORT_PINNED_KEY = |
There was a problem hiding this comment.
Shouldn't "key" be plural?
There was a problem hiding this comment.
hmm dont think so ? Its one key ? or am i missing something ?
There was a problem hiding this comment.
It's either 'Sandbox does not support pinned keys' (in general) or 'Sandbox does not support the usage of a pinned key' (singular).
|
@sandervdo pushed, please 👀 |
sandervdo
suggested changes
May 29, 2018
src/Http/ApiClient.php
Outdated
| const ERROR_MAC_OS_CURL_VERSION = 'Your PHP seems to be linked to the MacOS provided curl binary. ' . | ||
| 'This is incompatible with our SDK, please reinstall by running: "brew reinstall %s --with-homebrew-curl".%s'; | ||
| const ERROR_CURL_DOES_NOT_SUPPORT_ROOT_CA_PINNING = | ||
| 'Curl does not support root CA pinning. See https://curl.haxx.se/docs/todo.html#Support_intermediate_root_pinn'; |
There was a problem hiding this comment.
Why did you change the entire sentence..... The formulation is incorrect now; curl does not support root "Certificate Authority" pinning. 😂 The Authorities are not pinned, it's the certificate that gets pinned.
|
@sandervdo pushed. |
sandervdo
previously approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #149
Should be merged after the other issues are close.