Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readme for tests. #16

Merged
merged 10 commits into from
Aug 5, 2017
Merged

Add readme for tests. #16

merged 10 commits into from
Aug 5, 2017

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Aug 4, 2017

  • Renamed test to tests.
  • Changed some abbreviations.
  • Added readme for tests.
  • Added reference in main readme.

@OGKevin OGKevin self-assigned this Aug 4, 2017
@OGKevin OGKevin requested a review from dnl-blkv August 4, 2017 12:38
OGKevin
OGKevin commented Aug 4, 2017
View reviewed changes
tests/README.md Outdated

```
vendor/phpunit/phpunit/phpunit test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra new line 👀

@OGKevin OGKevin removed the request for review from dnl-blkv August 4, 2017 12:41
@OGKevin
Copy link
Contributor Author

OGKevin commented Aug 4, 2017

Need to re-add the JSON parser test 🙄

@OGKevin OGKevin closed this Aug 4, 2017
@OGKevin OGKevin reopened this Aug 4, 2017
@OGKevin OGKevin requested a review from dnl-blkv August 4, 2017 12:51
dnl-blkv
dnl-blkv suggested changes Aug 5, 2017
View reviewed changes
Copy link
Contributor

@dnl-blkv dnl-blkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

composer.json
@@ -31,7 +31,7 @@
},
"autoload-dev": {
"psr-4": {
"bunq\\test\\": "test/"
"bunq\\test\\": "tests/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, if tests are moving from test to tests, please also update the test configuration (phpunit.xml) :P

Yes, I fixed it in another MR... :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

tests/README.md Outdated
@@ -0,0 +1,52 @@
# bunq PHP SDK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be add "tests" here?

tests/README.md Outdated
@@ -0,0 +1,52 @@
# bunq PHP SDK
Version 0.9.0 **BETA**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go, as we've discussed :)

OGKevin
OGKevin commented Aug 5, 2017
View reviewed changes
README.md Outdated
@@ -1,6 +1,5 @@
# bunq PHP SDK
Version 0.9.0 **BETA**

gs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gs?

dnl-blkv
dnl-blkv reviewed Aug 5, 2017
View reviewed changes
Copy link
Contributor

@dnl-blkv dnl-blkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is gs? :D

README.md Outdated
@@ -1,6 +1,5 @@
# bunq PHP SDK
Version 0.9.0 **BETA**

gs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gs?

@OGKevin OGKevin requested a review from dnl-blkv August 5, 2017 08:37
@OGKevin
Copy link
Contributor Author

OGKevin commented Aug 5, 2017

Tests passing @dnl-blkv 🎊

@dnl-blkv dnl-blkv merged commit d31f47b into master Aug 5, 2017
@dnl-blkv dnl-blkv deleted the feature/test_readme branch August 5, 2017 08:47
@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 5, 2017

@andrederoos

@OGKevin OGKevin added this to the Patch 0.9.1 milestone Aug 5, 2017
@OGKevin OGKevin removed this from the Patch 0.9.2 milestone Aug 21, 2017
@OGKevin OGKevin modified the milestones: v0.10.0, Patch 0.9.2 Aug 21, 2017
@WouterFlorijn WouterFlorijn mentioned this pull request Jul 4, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnl-blkv dnl-blkv dnl-blkv approved these changes

Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OGKevin @dnl-blkv