Fix NotificationFilter, Model issues and implement PSD2 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrederoos
requested changes
Sep 9, 2019
README.md
Outdated
| @@ -84,6 +84,31 @@ BunqContext::loadApiContext($apiContext); | |||
|
|
|||
| **Tip:** both saving and restoring the context can be done without any arguments. In this case the context will be saved to/restored from the `bunq.conf` file in the same folder with your script. | |||
|
|
|||
| ##### PSD2 | |||
|
|
|||
src/Context/ApiContext.php
Outdated
| * @param BunqEnumApiEnvironmentType $environmentType | ||
| * @param Certificate $publicCertificate | ||
| * @param PrivateKey $privateKey | ||
| * @param array $allChainCertificate |
There was a problem hiding this comment.
array of strings? or Certificate?
src/Context/ApiContext.php
Outdated
| * @param PrivateKey $privateKey | ||
| * @param array $allChainCertificate | ||
| * @param string $description | ||
| * @param array $allPermittedIp |
There was a problem hiding this comment.
same. is this an array of objects?
| */ | ||
| private function initializeAllDefinitionIfNeeded() | ||
| { | ||
| if (defined(self::CURL_FIELD_KEY_PINNING)) { |
There was a problem hiding this comment.
put a comment why (and for which php version we do this
src/Model/Core/BunqModel.php
Outdated
| @@ -349,6 +354,21 @@ protected static function fromJson(BunqResponseRaw $responseRaw, string $wrapper | |||
| return new BunqResponse($value[self::INDEX_FIRST], $responseRaw->getHeaders()); | |||
| } | |||
|
|
|||
| /** | |||
| * @param $path | |||
| * @return string | ||
| * @throws BunqException | ||
| */ | ||
| private static function determineTokenUriFormat() |
| */ | ||
| class PaymentServiceProviderCredentialInternal extends PaymentServiceProviderCredential | ||
| { | ||
|
|
| * with the private key belonging to the QSEAL | ||
| * certificate. | ||
| * @param ApiContext $apiContext | ||
| * @param array $allCustomHeader |
| string $clientPublicKeySignature, | ||
| ApiContext $apiContext, | ||
| array $allCustomHeader = [] | ||
| ) { |
| protected static function fromRawResponse(BunqResponseRaw $responseRaw): BunqResponse | ||
| { | ||
| $allCredential = UserCredentialPasswordIp::fromJson($responseRaw, self::FIELD_OBJECT_TYPE); | ||
| return new BunqResponseUserCredentialPasswordIp($allCredential->getValue(), $responseRaw->getHeaders()); |
There was a problem hiding this comment.
always empty line above return
andrederoos
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues:
merchant_category_codein thecounterparty_alias#171 - Models regenerated