Add PHP-CS and PHPStan dependencies and scripts to execute #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not go one step further with the use of GrumPHP? So every commit will be checked instead of manual running de Composer scripts. And I would expect a configuration file for the tools so I can run the same commands outside the Composer script wrappers. |
|
@cafferata if you'd like to add GrumPHP, please create an issue for it :) |
|
@dnl-blkv I will see if I can send a pull request for this tonight |
Merged
This was referenced Sep 3, 2018
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So you can run:
composer phpstan=> results in 10 errors!composer phpcs-fix