Fixes #36 on php5.6 #37
Conversation
example/api_context_save_example.php
Outdated
| @@ -15,5 +15,6 @@ | |||
| const DEVICE_DESCRIPTION = 'Server 1'; | |||
| const PERMITTED_IPS = []; | |||
|
|
|||
| date_default_timezone_set('UTC'); // When using php5.6 | |||
There was a problem hiding this comment.
Oh btw... Are server responses indeed in UTC? Which timezone do we want to stick to in there?
There was a problem hiding this comment.
@dnl-blkv it appears that UTC is returned. But this is not documenten on the docs 馃.
There was a problem hiding this comment.
hmm, then we probably want to set this as a default for all times the date is used... In some entry point of the SDK perhaps, or just create a date wrapper with UTC to use there %)
There was a problem hiding this comment.
@OGKevin let's remove this line for now and address it as a separate issue! :)
OGKevin
requested review from
dnl-blkv
and removed request for
qurben and
andrederoos
|
@OGKevin the fatal still exists in |
|
@andrederoos Wel the particular error in #36 is fixed with this pr, however the structure we've chosen for the SDK doesn't seem to like php 5.6. We were debating on dropping 5.6 or not but have't come to a decision yet. Based on this decision we can see what we can do with the fatal. |
|
@OGKevin What is the fatal happening here? |
|
@dnl-blkv The avatar fatal Because there are 2 |
|
@OGKevin Could you please create an issue for it? (No there are no two |
|
ack, #38 |
This should fix the error shown in #36.
However the
avatarfatal is still present when using/sdk_php/src/Model/Generated/MonetaryAccountBank.php馃Tests passes on
php7.1.