Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toJson() fails on ApiContext of an user person due to session context #57

Merged
merged 1 commit into from
Oct 11, 2017
Merged

toJson() fails on ApiContext of an user person due to session context #57

merged 1 commit into from
Oct 11, 2017

Conversation

DennisSnijder
Copy link
Contributor

@DennisSnijder DennisSnijder commented Oct 11, 2017 •
edited

Context

#56

What has been done

  • Removed the strict types from the getters in the SessionContext class.

Notes

Once the Bunq PHP SDK drops 7.0 support they can use PHP7.1 nullable strict return types.
Example : getUserCompany(): ?UserCompany

fixes #56

@OGKevin
Copy link
Contributor

OGKevin commented Oct 11, 2017 •
edited

@dnl-blkv Fix confirmed 👍
Do we want to add a comment saying why we are not using strict types here ?

Thx for submitting this pr @DennisSnijder 🎖

@OGKevin OGKevin requested a review from dnl-blkv October 11, 2017 18:03
@dnl-blkv dnl-blkv merged commit c762f6c into bunq:develop Oct 11, 2017
@dnl-blkv
Copy link
Contributor

Thanks @DennisSnijder

@dnl-blkv
Copy link
Contributor

@andrederoos

@OGKevin
Copy link
Contributor

OGKevin commented Oct 11, 2017

Congrats on your first PR @DennisSnijder 👏 🎖

@DennisSnijder
Copy link
Contributor Author

@OGKevin Thanks! 😄 (Hopefully more to come)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OGKevin OGKevin OGKevin approved these changes

@dnl-blkv dnl-blkv Awaiting requested review from dnl-blkv

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toJson() fails on ApiContext of an user person due to session context
3 participants
@DennisSnijder @OGKevin @dnl-blkv