Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info to templates. (bunq/sdk_php#89) #90

Merged
merged 8 commits into from
Jan 2, 2018
Merged

Add more info to templates. (bunq/sdk_php#89) #90

merged 8 commits into from
Jan 2, 2018

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Dec 25, 2017 •
edited

Closes #89

OGKevin
OGKevin commented Dec 25, 2017
View reviewed changes
Copy link
Contributor Author

@OGKevin OGKevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 🙃

.github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -0,0 +1,8 @@
[//]: # (Thanks for opening this pull request! Before you procees please make sure that you've an issue that explains what this pull request will do.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proceed 😁

@OGKevin OGKevin added this to the 0.12.5 milestone Dec 25, 2017
@OGKevin OGKevin self-assigned this Dec 25, 2017
@OGKevin OGKevin force-pushed the feature/bunq/sdk_php#89-imporve-issue-and-pr-tempplate branch from e7bc7eb to d07ab38 Compare December 27, 2017 13:04
@OGKevin
Copy link
Contributor Author

OGKevin commented Dec 27, 2017

@sandervdo please 👀 at this one.

sandervdo
sandervdo reviewed Dec 27, 2017
View reviewed changes
Copy link
Contributor

@sandervdo sandervdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OGKevin go go go. 🚀

.github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -0,0 +1,8 @@
[//]: # (Thanks for opening this pull request! Before you proceed please make sure that you've an issue that explains what this pull request will do.
Make sure that all your commits link this issue e.g "My commit \(bunq/sdk_php#<issue nr>\)".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to this issue

.github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -0,0 +1,8 @@
[//]: # (Thanks for opening this pull request! Before you proceed please make sure that you've an issue that explains what this pull request will do.
Make sure that all your commits link this issue e.g "My commit \(bunq/sdk_php#<issue nr>\)".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. (second period is missing)

.github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -0,0 +1,8 @@
[//]: # (Thanks for opening this pull request! Before you proceed please make sure that you've an issue that explains what this pull request will do.
Make sure that all your commits link this issue e.g "My commit \(bunq/sdk_php#<issue nr>\)".
If this pr is changing files that are located in "src/Model/Generated" then this PR will be closed as these files must/can only be changed on bunq's side.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr -> Pull Request

.github/PULL_REQUEST_TEMPLATE.md Outdated
If this pr is changing files that are located in "src/Model/Generated" then this PR will be closed as these files must/can only be changed on bunq's side.)

## This PR closes/fixes the following issues:
[//]: # (If for some reason your PR does not require a pull request you can just mark this box as checked.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR does not require a PR? Whut? 😋

@OGKevin OGKevin force-pushed the feature/bunq/sdk_php#89-imporve-issue-and-pr-tempplate branch from 7a6e1cf to 33ca848 Compare December 27, 2017 15:03
@OGKevin
Copy link
Contributor Author

OGKevin commented Dec 27, 2017 •
edited

@sandervdo all yours again xD 😂 .

sandervdo
sandervdo previously approved these changes Dec 27, 2017
View reviewed changes
@OGKevin OGKevin assigned andrederoos and unassigned sandervdo Dec 27, 2017
@OGKevin
Copy link
Contributor Author

OGKevin commented Dec 27, 2017

@andrederoos all yours 🌈

sandervdo
sandervdo previously approved these changes Dec 27, 2017
View reviewed changes
Copy link
Contributor

@sandervdo sandervdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't hit the approve button apparently. 😛

@andrederoos
Copy link
Contributor

@OGKevin branche is out-of-date

@OGKevin OGKevin force-pushed the feature/bunq/sdk_php#89-imporve-issue-and-pr-tempplate branch from a7fed6b to af228b9 Compare January 2, 2018 09:29
@OGKevin
Copy link
Contributor Author

OGKevin commented Jan 2, 2018

@andrederoos my bad, updated 👍

@andrederoos andrederoos merged commit aaeefe2 into develop Jan 2, 2018
@andrederoos andrederoos deleted the feature/bunq/sdk_php#89-imporve-issue-and-pr-tempplate branch January 2, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrederoos andrederoos andrederoos approved these changes

@sandervdo sandervdo sandervdo left review comments

Assignees

@andrederoos andrederoos

@OGKevin OGKevin

Labels
Can be merged Reviewed by André
Projects
None yet
Milestone
0.12.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OGKevin @andrederoos @sandervdo @herkogabor1985