Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DraftPayment object field causes converter error #36

Closed
OGKevin opened this issue Oct 31, 2017 · 0 comments
Closed

DraftPayment object field causes converter error #36

OGKevin opened this issue Oct 31, 2017 · 0 comments
Assignees
@OGKevin
Labels
bug needs code regeneration
Milestone
0.12.2

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Oct 31, 2017

Steps to reproduce:

  1. Use the PHP Pub API SDK
  2. Make a draft payment via the SDK
  3. Accept this draft payment
  4. Retrieve this draft payment

What should happen:

  1. The SDK will raise and error as described here Getting a DraftPayment that has been ACCEPTED results in an error sdk_php#63

What happens:

  1. No error is raised

Extra info:

  • Tested on SDK release 0.12.1
  • This is an issue with all SDK's
@OGKevin OGKevin added the bug label Oct 31, 2017
@OGKevin OGKevin added this to the 0.12.1 milestone Oct 31, 2017
@OGKevin OGKevin self-assigned this Oct 31, 2017
OGKevin added a commit that referenced this issue Nov 8, 2017
@OGKevin
Added new DraftPaymentAnchorObject #36
89f6f5d
OGKevin added a commit that referenced this issue Nov 8, 2017
@OGKevin
Updated DraftPayment to use DraftPaymentAnchorObject #36
c06eb0b
@OGKevin OGKevin mentioned this issue Nov 8, 2017
Merged
dnl-blkv added a commit that referenced this issue Nov 8, 2017
@dnl-blkv
Merge pull request #39 from bunq/feature/fix_draftPayment_object_#36
a5ef267 
Feature/fix draft payment object #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
bug needs code regeneration
Projects
None yet
Milestone
0.12.2
Development

No branches or pull requests
1 participant
@OGKevin