Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto save the session after automatic session reset has been executed  #65

Closed
OGKevin opened this issue Dec 29, 2017 · 0 comments
Closed

Auto save the session after automatic session reset has been executed  #65

OGKevin opened this issue Dec 29, 2017 · 0 comments
Assignees
@OGKevin
Labels
enhancement
Projects
1.0.0 - SDK

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Dec 29, 2017 •
edited
Loading

Steps to reproduce:

  1. Make a request with an expired session

What should happen:

  1. The session gets automatically reset before the actual call is made.
  2. The reset session should be saved after the reset. So that the next call has a fresh new session, instead of resetting the session again.
  3. The user should be able to turn the automatic session save off.

What happens:

  1. If implemented incorrectly, users will make 6 calls to session-server within 2 seconds because on each call the session needs to be reset.

Logs

  • Logs no logs

Extra info:

Reference

needs #78
@OGKevin OGKevin added this to the 0.13.0 milestone Dec 29, 2017
@OGKevin OGKevin self-assigned this Dec 29, 2017
@OGKevin OGKevin modified the milestones: 0.13.0, 0.13.5 Mar 27, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Mar 27, 2018
OGKevin added a commit that referenced this issue Apr 8, 2018
@OGKevin
Update bunqContext when apiContext has expired. (#65)
ff07b08
OGKevin added a commit that referenced this issue Apr 8, 2018
@OGKevin
Added test for auto update bunqContext. (#65)
f37f0a8
@OGKevin OGKevin mentioned this issue Apr 8, 2018
Merged
@OGKevin OGKevin moved this from To do to pending review in 1.0.0 - SDK Apr 8, 2018
OGKevin added a commit that referenced this issue Apr 8, 2018
@OGKevin
Added missing doc blocks. (#65)
57790d6
OGKevin added a commit that referenced this issue Apr 8, 2018
@OGKevin
Removed un used import and fixed formatting. (#65)
829db29
OGKevin added a commit that referenced this issue May 1, 2018
@OGKevin
Merge pull request #86 from bunq/auto_update_bunq_context_bunq/sdk_py…
f751550 
…thon#65

Auto update bunq context #65
@OGKevin OGKevin closed this as completed May 1, 2018
1.0.0 - SDK automation moved this from pending review to Done May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
No open projects
1.0.0 - SDK
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OGKevin